Added an option to always display pagination #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1 UI requires disabled pagination controls even if there's only one page of data. |
|
+1. This definitely needs to be added =)! |
|
Sure, but it won't merge into |
This option will force rendering the pagination even if there is only one page to display.
|
Ok, here we go. |
|
+1 |
1 similar comment
|
+1 |
|
@mislav This looks like a great fork. Any reason to not have it in master? |
|
I've run another rebase against @mislav's master. It's at huerlisi/will_paginate branch show_always. |
|
+1 |
1 similar comment
|
+1 |
|
Nope. If you want to display fake links that do nothing, feel free to use your own helper as fallback <%= will_paginate(@posts) || fake_pagination %> |
|
Maybe I can accept @mislav 's solution…… |
|
Sure. It's not really a difficult problem to circumvent, but a question of coherence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase consistency of page layouts – even if there's only one page – it is handy to display pagination always. I added an option called
:show_alwaysthat can be used for that purpose.Example:
<%= will_paginate @collection, :show_always => true %>